Path fixes
Denys Duchier
duchier at ps.uni-sb.de
Mon Feb 12 19:54:01 CET 2007
Torsten Anders <torstenanders at gmx.de> writes:
> I fixed several issues in mozart-stdlib/os/Path.oz. Attached is a diff. In case
> nobody objects I will commit these changes.
Hi Torsten,
First: thank you for these patches.
However, I'd like you to hold off on these until I can review. Also, I don't
know if it's practical, but these are not small changes, and it is easier to
review small, well documented changes. The ideal way to do this is by using a
branch where each commit makes a small well-documented change. I realize svn is
not well suited to small short-lived branches, which is why ideally I'd really
prefer to use bzr (at least for this purpose). Of course, I am not asking you
to redo these proposed changes just to suit my preferences, but it might be nice
to consider my suggestion in the future.
Still, if you could also provide the documentation that might go in the future
commit message, that would be helpful ;-)
Cheers,
--Denys
More information about the mozart-hackers
mailing list